expr: stub protobuf support for BinaryFunc
#11803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexandrov
added
C-feature
aalexandrov
force-pushed
the
protobuf_binary_func
branch
from
9996a26
to
934f4f7
Compare
wangandi
reviewed
Apr 14, 2022
aalexandrov
force-pushed
the
protobuf_binary_func
branch
from
934f4f7
to
1149216
Compare
aalexandrov
changed the title
Arbitrary for BinaryFunc (incomplete)BinaryFunc (incomplete)
aalexandrov
changed the title
BinaryFunc (incomplete)BinaryFunc
aalexandrov
force-pushed
the
protobuf_binary_func
branch
4 times, most recently
from
a4e9ced
to
87aa8ab
Compare
wangandi
approved these changes
Apr 15, 2022
aalexandrov
force-pushed
the
protobuf_binary_func
branch
from
87aa8ab
to
0d247da
Compare
- Add `ProtoBinaryFunc` to `func.proto`. Variants that are not properly modeled as protobuf yet are prefixed with an `// unsupported:` comment. - Implement `From<&BinaryFunc> for ProtoBinaryFunc` in `func.rs`. Arms that are not yet supported have a `todo!()` placeholder. - Implement `TryFrom<ProtoBinaryFunc> for BinaryFunc` in `func.rs`. Arms that are not yet supported have a `todo!()` placeholder.
aalexandrov
force-pushed
the
protobuf_binary_func
branch
from
0d247da
to
53ab791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds partial protobuf support for
BinaryFunc.Motivation
First step towards resolving MaterializeInc/database-issues#3431.
Tips for reviewer
The first commit partially implements
ArbitraryforBinaryFunc.BinaryFunctowards closing MaterializeInc/database-issues#3431.The third commit changes things as follows:
ProtoBinaryFunctofunc.proto. Variants that are not properly modeled as protobuf yet are prefixed with an// unsupported:comment.From<&BinaryFunc> for ProtoBinaryFuncinfunc.rs. Arms that are not yet supported have atodo!()placeholder.TryFrom<ProtoBinaryFunc> for BinaryFuncinfunc.rs. Arms that are not yet supported have atodo!()placeholder.Testing
Test coverage has been added for the variants that are already supported. As we add more variants, we will need to expand the custom
Arbitraryimplementation forBinaryFuncto keep this invariant.Release notes
N/A
Footnotes
https://github.com/AltSysrq/proptest/issues/152 ↩